<html>
<head><meta charset="utf-8"><title>clippy subtree · t-compiler/major changes · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/index.html">t-compiler/major changes</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html">clippy subtree</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="196915751"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196915751" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196915751">(May 08 2020 at 16:11)</a>:</h4>
<p>FWIW the clippy thing has seemed to just work, though I do think we've not had a bump yet and such</p>



<a name="196915782"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196915782" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196915782">(May 08 2020 at 16:12)</a>:</h4>
<p>(and IIRC someone reported git subtree just segfaulting for them which is not great)</p>



<a name="196915847"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196915847" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196915847">(May 08 2020 at 16:12)</a>:</h4>
<p>yea, git subtree has problems</p>



<a name="196915860"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196915860" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196915860">(May 08 2020 at 16:12)</a>:</h4>
<p>they have an upstream fix</p>



<a name="196915867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196915867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196915867">(May 08 2020 at 16:12)</a>:</h4>
<p>but it hasn't been merged yet</p>



<a name="196915941"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196915941" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196915941">(May 08 2020 at 16:13)</a>:</h4>
<p>we can merge changes from clippy to rustc, but not the other way around without losing history</p>



<a name="196915960"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196915960" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196915960">(May 08 2020 at 16:13)</a>:</h4>
<p>so right now we're doing the merge changes from rustc to clippy manually</p>



<a name="196916079"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196916079" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196916079">(May 08 2020 at 16:14)</a>:</h4>
<p>ah okay</p>



<a name="196916083"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196916083" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196916083">(May 08 2020 at 16:14)</a>:</h4>
<p>(switched to a new topic)</p>



<a name="196916096"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196916096" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196916096">(May 08 2020 at 16:14)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@oli</span> do we have some sense for if we've "hit all the bugs" yet?</p>



<a name="196916110"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196916110" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196916110">(May 08 2020 at 16:15)</a>:</h4>
<p>or when you would feel comfortable making a call at least on whether to roll out further or not</p>



<a name="196916532"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196916532" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196916532">(May 08 2020 at 16:18)</a>:</h4>
<p>I wouldn't roll out further until we either get the upstream thing merged and have an easy way of running upstream git anywhere, or have a script that does the "lose history push" for us in a nice encapsulated way</p>



<a name="196916595"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196916595" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196916595">(May 08 2020 at 16:19)</a>:</h4>
<p>we're discussing the upstream fix at <a href="https://github.com/rust-lang/rust-clippy/issues/5565" title="https://github.com/rust-lang/rust-clippy/issues/5565">https://github.com/rust-lang/rust-clippy/issues/5565</a></p>



<a name="196916740"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196916740" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196916740">(May 08 2020 at 16:20)</a>:</h4>
<p>basically I just need to find a day where I'm feeling up to diving into very dense bash scripts and documenting the patch's changes. The actual implementation is already there</p>



<a name="196929410"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196929410" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196929410">(May 08 2020 at 18:00)</a>:</h4>
<p>FWIW we can totally host some git binaries for y'all to download as needed.</p>



<a name="196929454"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196929454" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196929454">(May 08 2020 at 18:00)</a>:</h4>
<p>I presume that's not really "the issue" though.</p>



<a name="196929544"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/clippy%20subtree/near/196929544" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/clippy.20subtree.html#196929544">(May 08 2020 at 18:01)</a>:</h4>
<p>Let me know please if there's something I can do to help or when you get it resolved</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>